-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Button-367] Refactoring #701
Conversation
7c527c0
to
4e913ab
Compare
core/Sources/Components/Button/View/UIKit/Button/ButtonUIView.swift
Outdated
Show resolved
Hide resolved
core/Sources/Components/Button/Manager/Main/ButtonMainManager.swift
Outdated
Show resolved
Hide resolved
core/Sources/Components/Button/Manager/Main/ButtonMainManager.swift
Outdated
Show resolved
Hide resolved
core/Sources/Components/Button/Manager/Main/ButtonMainManagerTests.swift
Outdated
Show resolved
Hide resolved
core/Sources/Components/Button/View/SwiftUI/Internal/ButtonContentView.swift
Outdated
Show resolved
Hide resolved
core/Sources/Components/Button/View/SwiftUI/Internal/ButtonContentView.swift
Outdated
Show resolved
Hide resolved
core/Sources/Components/Button/View/SwiftUI/Public/Button/ButtonView.swift
Outdated
Show resolved
Hide resolved
core/Sources/Components/Button/View/SwiftUI/Public/Button/ButtonView.swift
Outdated
Show resolved
Hide resolved
core/Sources/Components/Button/View/SwiftUI/Public/Button/ButtonView.swift
Outdated
Show resolved
Hide resolved
core/Sources/Components/Button/View/SwiftUI/Internal/ButtonContentView.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the SwiftUI button there are some state changes not reflected:
Given:
- normal state: none
- highlighted state: text/Image ....
When: the button is pressed
Then: the button doesn't change
Given: - normal state: Image and attributed text
- highlighted: none
When: the button is pressed
Then: an icon is shown
And different combinations such as above
@michael-zimmermann, So, I update the code:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the ControlStatus can remain as a struct
👍 Looks good
Content:
This pull request has: