[Popover] Added demos

spark/Demo/AppDelegate.swift → .Demo/App/AppDelegate.swift

@@ -7,6 +7,8 @@
 //
 
 import UIKit
+@_exported import SparkCore
+@_exported import SparkCoreTesting
 
 /// Appdelegate was added for starting app with a viewcontroller. So It help us to integrate UIkit components to UIViewController class diretly. SwiftUI components are working on UIHostingController class more stablize than UIkit components that was integrated with a UIViewRepresentable class.
 @main

spark/Demo/SceneDelegate.swift → .Demo/App/SceneDelegate.swift

@@ -8,8 +8,6 @@
 
 import UIKit
 
-// swiftlint:disable all
-
 class SceneDelegate: UIResponder, UIWindowSceneDelegate {
 
     var window: UIWindow?

spark/Demo/Classes/Enum/UIComponent.swift → .Demo/Classes/Enum/UIComponent.swift

@@ -18,6 +18,7 @@ struct UIComponent: RawRepresentable, CaseIterable, Equatable {
         .chip,
         .formField,
         .icon,
+        .popover,
         .progressBarIndeterminate,
         .progressBarSingle,
         .progressTracker,
@@ -45,6 +46,7 @@ struct UIComponent: RawRepresentable, CaseIterable, Equatable {
     static let formField = UIComponent(rawValue: "FormField")
     static let icon = UIComponent(rawValue: "Icon")
     static let iconButton = UIComponent(rawValue: "Icon Button")
+    static let popover = UIComponent(rawValue: "Popover")
     static let progressBarIndeterminate = UIComponent(rawValue: "Progress Bar Indeterminate")
     static let progressBarSingle = UIComponent(rawValue: "Progress Bar Single")
     static let progressTracker = UIComponent(rawValue: "Progress Tracker")

spark/Demo/Classes/DemoIconography.swift → .Demo/Classes/Iconography/DemoIconography.swift

@@ -6,7 +6,7 @@
 //  Copyright © 2023 Adevinta. All rights reserved.
 //
 
-import Spark
+@_spi(SI_SPI) import SparkCommon
 import SwiftUI
 import SparkCore
 

spark/Demo/Classes/Tabbar/ConsoleView.swift → .Demo/Classes/Tabbar/ConsoleView.swift

@@ -9,6 +9,7 @@
 import Combine
 import Foundation
 import UIKit
+@_spi(SI_SPI) import SparkCommon
 
 final class Console {
     static var publisher: some Publisher<String, Never> {
@@ -20,7 +21,7 @@ final class Console {
     }
 }
 
-final class ConsoleView: UIView {
+public final class ConsoleView: UIView {
 
     enum Constants {
         static let fullWidth: CGFloat = 200
@@ -29,7 +30,7 @@ final class ConsoleView: UIView {
 
     private var dataSource = [String]()
 
-    static let shared = ConsoleView()
+    public static let shared = ConsoleView()
 
     private var width: CGFloat {
         return self.consoleButton.isSelected ? Constants.fullWidth : Constants.collapsedWidth
@@ -87,7 +88,7 @@ final class ConsoleView: UIView {
         fatalError("init(coder:) has not been implemented")
     }
 
-    func show() {
+    public func show() {
         guard let window = UIApplication.shared.windows.last else {
             return
         }
@@ -178,18 +179,18 @@ final class ConsoleView: UIView {
 }
 
 extension ConsoleView: UITableViewDelegate {
-    func tableView(_ tableView: UITableView, estimatedHeightForRowAt indexPath: IndexPath) -> CGFloat {
+    public func tableView(_ tableView: UITableView, estimatedHeightForRowAt indexPath: IndexPath) -> CGFloat {
         return 12.0
     }
 }
 
 extension ConsoleView: UITableViewDataSource {
 
-    func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
+    public func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
         return section == 0 ? self.dataSource.count : 0
     }
 
-    func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
+    public func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
         guard let cell = self.tableView.dequeueReusableCell(withIdentifier: ConsoleTableViewCell.cellIdentifier) as? ConsoleTableViewCell else {
             fatalError("Couldn't dequeue table view cell")
         }

spark/Demo/Classes/Tabbar/SparkTabbarController.swift → .Demo/Classes/Tabbar/SparkTabbarController.swift

@@ -8,11 +8,10 @@
 
 import UIKit
 import SwiftUI
-import Spark
 import SparkCore
 import Combine
 
-final class SparkTabbarController: UITabBarController {
+public final class SparkTabbarController: UITabBarController {
 
     // MARK: - Published Properties
     @ObservedObject private var themePublisher = SparkThemePublisher.shared
@@ -52,7 +51,7 @@ final class SparkTabbarController: UITabBarController {
     }()
 
     // MARK: - ViewDidLoad
-    override func viewDidLoad() {
+    public override func viewDidLoad() {
         super.viewDidLoad()
 
         self.loadSparkConfiguration()
@@ -77,9 +76,9 @@ final class SparkTabbarController: UITabBarController {
         self.themePublisher
             .$theme
             .eraseToAnyPublisher()
-            .sink(receiveValue: { theme in
-                self.tabBar.tintColor = theme.colors.main.main.uiColor
-            })
-            .store(in: &cancellables)
+            .sink { theme in
+            self.tabBar.tintColor = theme.colors.main.main.uiColor
+        }
+        .store(in: &cancellables)
     }
 }

spark/Demo/Classes/Theme/SparkThemePublisher.swift → .Demo/Classes/Theme/SparkThemePublisher.swift

@@ -8,7 +8,6 @@
 
 import Foundation
 import SparkCore
-import Spark
 
 public class SparkThemePublisher: ObservableObject {
     public static let shared = SparkThemePublisher()

spark/Demo/Classes/View/Components/Badge/BadgePreviewFormatter.swift → .Demo/Classes/View/Components/Badge/BadgePreviewFormatter.swift

@@ -6,7 +6,7 @@
 //  Copyright © 2023 Adevinta. All rights reserved.
 //
 
-import Spark
+@_spi(SI_SPI) import SparkCommon
 import SparkCore
 import SwiftUI
 

spark/Demo/Classes/View/Components/Badge/SwiftUI/BadgeComponentView.swift → .Demo/Classes/View/Components/Badge/SwiftUI/BadgeComponentView.swift

@@ -6,7 +6,7 @@
 //  Copyright © 2023 Adevinta. All rights reserved.
 //
 
-import Spark
+@_spi(SI_SPI) import SparkCommon
 import SparkCore
 import SwiftUI
 

spark/Demo/Classes/View/Components/Badge/UIKit/BadgeComponentUIView.swift → .Demo/Classes/View/Components/Badge/UIKit/BadgeComponentUIView.swift

@@ -9,7 +9,7 @@
 import UIKit
 import Combine
 import SparkCore
-import Spark
+@_spi(SI_SPI) import SparkCommon
 
 final class BadgeComponentUIView: UIView {
 

spark/Demo/Classes/View/Components/Badge/UIKit/BadgeComponentUIViewModel.swift → .Demo/Classes/View/Components/Badge/UIKit/BadgeComponentUIViewModel.swift

@@ -7,7 +7,7 @@
 //
 
 import Combine
-import Spark
+@_spi(SI_SPI) import SparkCommon
 import SparkCore
 import UIKit
 

spark/Demo/Classes/View/Components/Badge/UIKit/BadgeComponentViewController.swift → .Demo/Classes/View/Components/Badge/UIKit/BadgeComponentViewController.swift

@@ -7,10 +7,10 @@
 //
 
 import Combine
-import Spark
 import SwiftUI
 import UIKit
 import SparkCore
+@_spi(SI_SPI) import SparkCommon
 
 final class BadgeComponentViewController: UIViewController {
 
@@ -51,11 +51,11 @@ final class BadgeComponentViewController: UIViewController {
 
         themePublisher
             .$theme
-            .sink(receiveValue: { [weak self] theme in
+            .sink { [weak self] theme in
                 guard let self = self else { return }
                 self.viewModel.theme = theme
                 self.navigationController?.navigationBar.tintColor = theme.colors.main.main.uiColor
-            })
+            }
             .store(in: &self.cancellables)
 
         self.viewModel.showThemeSheet.subscribe(in: &self.cancellables) { intents in

spark/Demo/Classes/View/Components/BottomSheet/SwiftUI/BottomSheetPresentedView.swift → .Demo/Classes/View/Components/BottomSheet/SwiftUI/BottomSheetPresentedView.swift

@@ -10,9 +10,9 @@ import SwiftUI
 
 struct BottomSheetPresentedView: View {
     var description: String = """
-Sample of a SwiftUI bottom sheet with little text.
-🧡💙
-"""
+     Sample of a SwiftUI bottom sheet with little text.
+     🧡💙
+     """
     var dismiss: () -> Void
 
     var body: some View {

spark/Demo/Classes/View/Components/BottomSheet/SwiftUI/BottomSheetPresentingView.swift → .Demo/Classes/View/Components/BottomSheet/SwiftUI/BottomSheetPresentingView.swift

@@ -9,70 +9,70 @@
 import SwiftUI
 
 private let longDescription: String = """
-Sample of a SwiftUI bottom sheet with a scroll view.
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-"""
+ Sample of a SwiftUI bottom sheet with a scroll view.
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ """
 private let mediumDescription: String = """
-Sample of a SwiftUI bottom sheet with a long text.
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-💙
-🧡
-"""
+ Sample of a SwiftUI bottom sheet with a long text.
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ 💙
+ 🧡
+ """
 struct BottomSheetPresentingView: View {
     var body: some View {
         if #available(iOS 16.4, *) {
@@ -121,12 +121,12 @@ struct BottomSheetPresentingViewWithHeightDetent: View {
                 self.showingLongSheet.toggle()
             }
             .sheet(isPresented: $showingLongSheet) {
-                    ScrollView {
-                        BottomSheetPresentedView(description: longDescription) {
-                            self.showingLongSheet.toggle()
-                        }
+                ScrollView {
+                    BottomSheetPresentedView(description: longDescription) {
+                        self.showingLongSheet.toggle()
                     }
-                    .scrollIndicators(.visible)
+                }
+                .scrollIndicators(.visible)
                 .presentationDetents([.medium, .large])
             }
             .buttonStyle(.borderedProminent)

spark/Demo/Classes/View/Components/Button/SwiftUI/ButtonComponentView.swift → .Demo/Classes/View/Components/Button/SwiftUI/ButtonComponentView.swift

@@ -7,7 +7,7 @@
 //
 
 import SwiftUI
-import Spark
+@_spi(SI_SPI) import SparkCommon
 import SparkCore
 
 struct ButtonComponentView: View {
@@ -194,7 +194,6 @@ private extension ButtonView {
                 case .highlighted: image = Image("close")
                 case .disabled: image = Image("check")
                 case .selected: image = Image("alert")
-                @unknown default: break
                 }
             }
 
@@ -221,7 +220,6 @@ private extension ButtonView {
             case .highlighted: title = "My Highlighted"
             case .disabled: title = "My Disabled"
             case .selected: title = "My Selected"
-            @unknown default: break
             }
 
             if content.containsAttributedText, let title {