Dynamic theme switching #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture/demo/dynamic-theme-switching
michael-zimmermann
previously approved these changes
Jun 13, 2023
|
|
||
| let bodyFontMetrics = UIFontMetrics(forTextStyle: .body) | ||
| let padding = bodyFontMetrics.scaledValue(for: self.spacing.medium) - self.controlBorderWidth | ||
| let wideSpacing = bodyFontMetrics.scaledValue(for: self.spacing.xxxLarge) - self.controlBorderWidth |
There was a problem hiding this comment.
I added the wideSpacing here. According to the specs, the spacing is to be xxxLarge when the label is left aligned.
There was a problem hiding this comment.
Thanks for fixing :)
| @@ -230,20 +238,20 @@ public final class CheckboxUIView: UIView { | |||
| case .right: | |||
| textLabel.topAnchor.constraint(equalTo: view.safeAreaLayoutGuide.topAnchor).isActive = true | |||
| textLabel.leadingAnchor.constraint(equalTo: view.safeAreaLayoutGuide.leadingAnchor, constant: 0).isActive = true | |||
| self.textLabelTrailingConstraint = textLabel.trailingAnchor.constraint(equalTo: controlView.leadingAnchor, constant: -padding) | |||
| self.textLabelTrailingConstraint = textLabel.trailingAnchor.constraint(equalTo: controlView.leadingAnchor, constant: -wideSpacing) | |||
There was a problem hiding this comment.
I added a wider spacing, when the label is left aligned.
michael-zimmermann
removed
the
Blocked
michael-zimmermann
force-pushed
the
feature/demo/dynamic-theme-switching
branch
from
19ed4ae
to
d64c313
Compare
….com/adevinta/spark-ios into feature/demo/dynamic-theme-switching
…ture/demo/dynamic-theme-switching
|
|
||
| let bodyFontMetrics = UIFontMetrics(forTextStyle: .body) | ||
| let padding = bodyFontMetrics.scaledValue(for: self.spacing.medium) - self.controlBorderWidth | ||
| let wideSpacing = bodyFontMetrics.scaledValue(for: self.spacing.xxxLarge) - self.controlBorderWidth |
LouisBorleeAdevinta
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To switch themes, just shake the device or Simulator: