Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component] Switch: Add SwiftUI version #455

Merged
merged 3 commits into from
Sep 21, 2023
Merged

[Component] Switch: Add SwiftUI version #455

merged 3 commits into from
Sep 21, 2023

Conversation

robergro
Copy link
Contributor

@robergro robergro commented Sep 19, 2023

This pull request has:

  • Code documentation on publics
  • Accessibility
    • Dynamic sizes
    • Identifiers
  • Tests
  • Demo update
  • Wiki

The snapshot testing review is here

Copy link
Contributor

@michael-zimmermann michael-zimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small comment


import Foundation

extension CGFloat {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clever, I like this.

Copy link
Contributor

@michael-zimmermann michael-zimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@robergro robergro merged commit 2ca15ed into main Sep 21, 2023
4 checks passed
@robergro robergro deleted the tech/switch/view branch September 21, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants