Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ProgressBar-203-376] Add all content data and logic #508

Merged
merged 2 commits into from
Oct 18, 2023
Merged

[ProgressBar-203-376] Add all content data and logic #508

merged 2 commits into from
Oct 18, 2023

Conversation

robergro
Copy link
Contributor

This PR contains all needed data for the three versions of the ProgressBar (default, double and indeterminate)

  • AccessibilityIdentifier
  • Constants
  • Enums
  • Model
  • UseCase
  • ViewModel

This was linked to issues Oct 13, 2023
[Component] Progress-bar #376
Closed
[Component] Progress-bar #203
Closed
jacklyn-situmorang
jacklyn-situmorang reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@jacklyn-situmorang jacklyn-situmorang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general everything looks great! I would just suggest renaming ProgressIndeterminateBar.... to ProgressBarIndeterminate...

...ources/Components/ProgressBar/Enum/Indeterminate/ProgressIndeterminateBarAnimationType.swift Outdated Show resolved Hide resolved
core/Sources/Components/ProgressBar/Enum/Indeterminate/ProgressIndeterminateBarStatus.swift Outdated Show resolved Hide resolved
core/Sources/Components/ProgressBar/ViewModel/Double/ProgressDoubleBarViewModel.swift Outdated Show resolved Hide resolved
core/Sources/Components/ProgressBar/ViewModel/Single/ProgressBarViewModel.swift Show resolved Hide resolved
@robergro robergro merged commit 66828fd into main Oct 18, 2023
4 checks passed
@robergro robergro deleted the component/progressbar/data branch October 18, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacklyn-situmorang jacklyn-situmorang jacklyn-situmorang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] Progress-bar [Component] Progress-bar
2 participants
@robergro @jacklyn-situmorang