[Snapshot-1544] Update the Tag snapshot #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,40 +6,35 @@ | |||
| // Copyright © 2023 Adevinta. All rights reserved. | |||
| // | |||
|
|
|||
| import UIKit | |||
| @testable import SparkCore | |||
|
|
|||
| struct TagSutSnapshotTests { | |||
There was a problem hiding this comment.
The name of this struct is strange.
SUT stands for Service Under Tests and is usually given to the variable name of the service being tested.
There was a problem hiding this comment.
I replace SUT to configuration
| for scenario in scenarios { | ||
| let suts = scenario.sut(isSwiftUIComponent: true) | ||
| for sut in suts { | ||
| let view = TagView(theme: self.theme) |
There was a problem hiding this comment.
In this case the view is the SUT and not the variations.
| /// - content: icon + text | ||
| /// - mode: all | ||
| /// - size: default | ||
| private func test1(isSwiftUIComponent: Bool) -> [TagSutSnapshotTests] { |
There was a problem hiding this comment.
The name of the function could be more descriptive, something like is in the comment.
Maybe the could be renamed to something like "scenarioAllIntents" .. etc. When I see a function starting with "test", I immediately assume, that it is a test.
| import SwiftUI | ||
|
|
||
| enum TagScenarioSnapshotTests: String, CaseIterable { | ||
| case test1 |
There was a problem hiding this comment.
The name of the scenarios could be more descriptive, see below.
robergro
force-pushed
the
refacto/tag/snapshot
branch
from
e804d6b
to
f896762
Compare
michael-zimmermann
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here the new strategy for the Snapshot !
This work was done with Elisa.
The link of the associated Google sheet: here
The new tests correspond to the list of tests define inside the Google sheet.
We have 5 scenarios for the Tag.
At the end, we have now 39 images for each framworks instead of 486...
The PR for the Snapshot testing is here.