Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] performance improvement by removing layoutIfNeeded #609

Merged
merged 1 commit into from
Nov 8, 2023
Merged

[Fix] performance improvement by removing layoutIfNeeded #609

merged 1 commit into from
Nov 8, 2023

Conversation

robergro
Copy link
Contributor

@robergro robergro commented Nov 8, 2023

  • Replace layoutIfNeeded to updateConstraintsIfNeeded when the updated value is a constraints
  • Move the layoutIfNeeded to the mandatory child view and not the parent

@robergro robergro linked an issue Nov 8, 2023 that may be closed by this pull request
[Fix] Bad performance due to layoutIfNeeded #610
Closed
@robergro robergro merged commit 9b3705b into main Nov 8, 2023
4 checks passed
@robergro robergro deleted the fix/layout branch November 8, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinzen vinzen vinzen approved these changes

@LouisBorleeAdevinta LouisBorleeAdevinta LouisBorleeAdevinta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] Bad performance due to layoutIfNeeded
3 participants
@robergro @vinzen @LouisBorleeAdevinta