[Slider#204] Implementation of SliderUIControl #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The demo app crashes, when I set the minimum value equal to the maximum value. Doing it the other way around doesn't cause a crash. |
…e (UISlider does indeed trigger a newValue even if the old one is equal to the new one)
LouisBorleeAdevinta
force-pushed
the
204-component-slider-develop
branch
from
14de8a3
to
76e8802
Compare
| get { return self.viewModel.minimumValue } | ||
| set { | ||
| self.viewModel.minimumValue = newValue | ||
| self.setValue(self.value) |
There was a problem hiding this comment.
The reads very strange. Setting the value of itself?
There was a problem hiding this comment.
It resets the value using the getClosestValueUseCase from the viewModel, min / max changes update the value
There was a problem hiding this comment.
I could add it in comment or create a func resetValue() whichever you prefer
There was a problem hiding this comment.
Yes, I went through the code to see what happens. At first glance, it just looks weird.
There was a problem hiding this comment.
I agree, let me do something about it :)
michael-zimmermann
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.