Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RadioButton#853] Fix size of radio button #856

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

aycil-alican
Copy link
Contributor

No description provided.

@aycil-alican aycil-alican added the ✅ Ready All the needed informations are detailed within the ticket to include it in another sprint label Mar 14, 2024
@aycil-alican
Copy link
Contributor Author

aycil-alican commented Mar 22, 2024

@michael-zimmermann When I change preview mode from portrait to landscape on UIKit, Radio button group leading position changes. Do you have any idea? You can check it on RadioCheckboxUIViewController

@michael-zimmermann
Copy link
Contributor

@michael-zimmermann When I change preview mode from portrait to landscape on UIKit, Radio button group leading position changes. Do you have any idea? You can check it on RadioCheckboxUIViewController.

No, I haven't seen that behavior yet. But create a separate ticket for it. I can't image, that it's related to the size.

@aycil-alican
Copy link
Contributor Author

On UIkit side the reason of issue leading position is safelayoutguide. Radio button uses safelayoutguide for leading alignment but checkbox don't use it. We should decide if we use safelayoutguide in components or not. According to this desicion we will fix one of them in different task.

@aycil-alican aycil-alican merged commit 8298c53 into main Mar 26, 2024
4 checks passed
@aycil-alican aycil-alican deleted the component/853_radio_button_bug branch March 26, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready All the needed informations are detailed within the ticket to include it in another sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants