Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "enum" attribute from deprecated "@type" property of icarResourceType #451

Closed
cookeac opened this issue Apr 4, 2024 · 1 comment · Fixed by #438
Closed

Remove "enum" attribute from deprecated "@type" property of icarResourceType #451

cookeac opened this issue Apr 4, 2024 · 1 comment · Fixed by #438
Assignees
@AlexeyHardCode

Comments

@cookeac
Copy link
Collaborator

cookeac commented Apr 4, 2024

The "enum" keyword in this context breaks code generation, and its in a deprecated property, so we will remove it.
@cookeac cookeac mentioned this issue Apr 4, 2024
Merged
cookeac added a commit to cookeac/ICAR that referenced this issue Apr 17, 2024
@cookeac
Remove enum from @type
87eed85 
@type is already deprecated, but the use of "enum": ["Link"] to provide a constant value causes errors in code generation under OpenAPI 3.1.
Fixes adewg#451
@cookeac
Copy link
Collaborator Author

cookeac commented Apr 17, 2024

@AlexeyHardCode I have added a commit to the 239-openapi-3.1 branch (PR #438) which fixes this. Can you check?

@cookeac cookeac mentioned this issue Apr 17, 2024
Merged
@cookeac cookeac linked a pull request Apr 29, 2024 that will close this issue
Update to OpenAPI version 3.1 #438
Merged
cookeac added a commit that referenced this issue May 2, 2024
@cookeac
Merge pull request #438 from adewg/239-openapi-3.1
df6e1b3 
Update to OpenAPI version 3.1
Resolves #239 
Resolves #451
@cookeac cookeac closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyHardCode AlexeyHardCode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to OpenAPI version 3.1 adewg/ICAR
2 participants
@cookeac @AlexeyHardCode