-
Notifications
You must be signed in to change notification settings - Fork 27
Technical Minutes 2022 02 24
- In attendance: Andrew C, Andreas S, Craig V, Erwin S, Graham M, Thomas P
Items to discuss today are: icarResource Discriminator property; streaming API for bulk data sharing; herd level milk recording
1. Milk recording information on herd level (#184)
Erwin described what he had been working on. He has tried to make it generic. He has called it icarStatistics. It has an id, a location, a purpose, a start and end date. There is a group array which has a group type, a denominator and a group specifier (the group type determines which fields are used). There is a statistics array which could have a number of measures (like kg milk, somatic cell count, % protein), the units, an aggregation and a value.
Some amendments were made to the proposed design during the meeting.
2. Current icarResource Discriminator property doesn't appear valid (#278)
Andreas said that he and Alexey have been in communication and have discovered the same problems. If discriminator is removed, inheritance is lost. It will lead to a lot of changes and code refactoring. Next they tried making the property required and to define the property in the classes (as the OpenAPI spec requires). This caused the property to be duplicated.
We are trying to make it work properly and get the specification right. The issue is that the code generation works at the moment for those who implemented it this way but because it is not true to the OpenAPI specification, someone else's code generation may fail if using another tool. It would be good if we could get to a method which works for everyone.
The discussion was inconclusive and will be continued at the next meeting.
Next meeting scheduled for 10 March 2022 at 8:15am CET