Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infra-apps): bump infra-apps to 0.173.0 to upgrade KPS to 49.2.0 #1092

Merged
merged 5 commits into from
Sep 1, 2023

Conversation

vmaillot
Copy link
Contributor

@vmaillot vmaillot commented Sep 1, 2023

Description

Bump infra-apps to 0.173.0 for KPS to 49.2.0 and use ServerSideApply for Argo CD Sync Policy in KPS.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@vmaillot vmaillot requested a review from a team as a code owner September 1, 2023 08:33
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 1, 2023
@tongpu
Copy link
Member

tongpu commented Sep 1, 2023

You should probably mention the change in the syncPolicy in both the PR description and mention it in the Artifacthub changes. This potentially also needs a bit of a word of warning with regards to breaking compatibility with Argo CD version which don't support ServerSideApply (I couldn't find when it was introduced in the changelog on first glance).

@hairmare
Copy link
Contributor

hairmare commented Sep 1, 2023

Argo CD version which don't support ServerSideApply

I don't think we support any of those anymore

… and add sync policy

Signed-off-by: Valentin Maillot <valentin.maillot@adfinis.com>
@vmaillot vmaillot force-pushed the feat/bump-kps-add-sync-policy branch from f373a2c to 99c4d87 Compare September 1, 2023 08:59
Signed-off-by: Valentin Maillot <valentin.maillot@adfinis.com>
@vmaillot vmaillot force-pushed the feat/bump-kps-add-sync-policy branch from 99c4d87 to 7c20ed8 Compare September 1, 2023 09:01
vmaillot and others added 3 commits September 1, 2023 11:04
Signed-off-by: Valentin Maillot <valentin.maillot@adfinis.com>
Co-authored-by: Lucas Bickel <116588+hairmare@users.noreply.github.com>
Signed-off-by: Valentin Maillot <valentin.maillot@adfinis.com>
@vmaillot vmaillot merged commit 3660a27 into main Sep 1, 2023
3 checks passed
@vmaillot vmaillot deleted the feat/bump-kps-add-sync-policy branch September 1, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants