Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update choices.js library to v9.0.1 #12

Merged
merged 2 commits into from
May 21, 2020
Merged

Conversation

raulfernandez
Copy link
Contributor

  • Update choices.js to version 9.0.1. Changes:
    • hiddenState className is removed.
    • itemOption className is replaced by itemChoice className.
    • New selectedState className is added.
    • fusejs.io updates from 2.7.4 to version 3.4.6. Changes:
      • New options added to FuseOptions:
        • includeMateches,
        • includeScore,
        • findAllMatches,
        • sortFn,
        • and getFn.
    • Changes on IchoicesProps:
      • addItemFilterFn renamed to addItemFilter. It also allows string and RegExp types.
      • sortFn renamed to sorter.
      • Added uniqueItemText.
      • Added customAddItemText.
      • Added valueComparer.
    • Removed ajax on IChoicesMethods.
  • Update @stencil/core to version 1.12.7.
  • Update other dev dependencies:
    • @babel/plugin-syntax-dynamic-import to version 7.8.3.
    • @stencil/sass to version 1.3.1.
    • @types/jest to version 25.2.1.
    • choices.js to version 9.0.1.
    • jest to version 25.5.2.
    • jest-dot-reporter to version 1.0.14.
    • rimraf to version 3.0.2.
    • tslint to version 6.1.2.
    • typedoc to version 0.17.6.
    • workbox-build to version 5.1.3.
    • fsevents to version 2.1.3.
  • Rename utils.tsx to utils.ts

Copy link
Member

@RecuencoJones RecuencoJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it LGTM, just some minor changes

package-lock.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/components/choicesjs-stencil/choicesjs-stencil.tsx Outdated Show resolved Hide resolved
src/components/choicesjs-stencil/interfaces.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@moelders moelders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example has to be updated to be able to work with the new properties.

CHANGELOG.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/components/choicesjs-stencil/choicesjs-stencil.tsx Outdated Show resolved Hide resolved
@moelders moelders added the enhancement New feature or request label May 5, 2020
Copy link
Member

@RecuencoJones RecuencoJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@moelders moelders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moelders moelders merged commit e0cdd4f into master May 21, 2020
@moelders moelders deleted the feature/update-choicejs branch May 21, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants