Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: update ChoicesJS #13

Merged
merged 3 commits into from
May 21, 2020
Merged

Bugfix: update ChoicesJS #13

merged 3 commits into from
May 21, 2020

Conversation

moelders
Copy link
Contributor

  • Fix multiple selector attributes to avoid inconsistencies.
  • Update public demo.
  • Update documentation and changelog.

@moelders moelders added bug Something isn't working enhancement New feature or request labels May 21, 2020
RecuencoJones
RecuencoJones approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@RecuencoJones RecuencoJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should we also update package.json or we didn't release yet previous PR?

@moelders moelders merged commit 580a869 into master May 21, 2020
@moelders moelders deleted the bugfix/update-choicesjs branch May 21, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RecuencoJones RecuencoJones RecuencoJones approved these changes

Assignees

@RecuencoJones RecuencoJones

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moelders @RecuencoJones