Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Add pre-commit checks to fix whitespace #1588

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bocan
Copy link

@bocan bocan commented Aug 31, 2024

What does this PR change? What problem does it solve?

This changes no functionality, but cleans up a number of code styling issues. I've added a pre-commit configuration file, that optionally allows one to run pre-commit install after cloning, and from then on when you commit changes, it will run pre-commit against the code.

Specifically, it's setup to check for unnecessary trailing whitespaces, mixed windows/unix line endings, and missing end-of-file markers.

Was the change discussed in an issue or in the Discussions before?

Yes, in #1584.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

bocan and others added 2 commits August 27, 2024 13:17
There are multiple whitespace issues in this codebase. This fixes them
all and creates an optional pre-commit check to avoid them coming back.
style: Add pre-commit checks to fix whitespace
Copy link

sonarcloud bot commented Aug 31, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant