Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Pyatoa import and install procedures broken #158

Merged
merged 15 commits into from
Mar 1, 2023
Merged

Conversation

bch0w
Copy link
Member

@bch0w bch0w commented Feb 28, 2023

Upstream changes to Pyadjoint and Pyatoa caused import statements and install procedures related to Pyatoa to break in the current version of SeisFlows, which does not have pins on the versions of Pyatoa and Pyadjoint. This caused new installations of SeisFlows to have incompatible versions of Pyatoa and Pyadjoint.

This PR fixes those bugs and updates install procedures to point to the newest PyPi version of Pyatoa (which in turn points to PyPi versions of its own dependencies).

  • Removes read_sem import from Pyatoa which was removed in Pyatoa < 0.2.2
  • Pins Pyatoa==0.2.2 to avoid bugs from previous Pyatoa versions
  • Fixes failing tests introduced in Preprocessing changes #155, all tests passing now
  • Fixes Pyaflowa tests that failed from Pyatoa changes < 0.2.2

@bch0w bch0w merged commit 4286efe into devel Mar 1, 2023
@bch0w bch0w deleted the bugfix_pyatoa branch March 1, 2023 01:34
@bch0w bch0w mentioned this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant