Issues 80: Fix typos in src/exec_state.cpp and src/parquet_impl.cpp

Additionally fix clang warning.
adjust · May 29, 2024 · b6929dc · b6929dc
1 parent e6d8107
commit b6929dc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/exec_state.cpp b/src/exec_state.cpp
@@ -235,7 +235,7 @@ class MultifileExecutionState : public ParquetFdwExecutionState
             ExecStoreVirtualTuple(slot);
         }
 
-        return res;
+        return res == RS_SUCCESS;
     }
 
     void rescan(void)

diff --git a/src/parquet_impl.cpp b/src/parquet_impl.cpp
@@ -393,7 +393,7 @@ row_group_matches_filter(parquet::Statistics *stats,
                 Datum   lower;
                 int     cmpres;
                 bool    satisfies;
-                std::string min = std::move(stats->EncodeMin());
+                std::string min = stats->EncodeMin();
 
                 lower = bytes_to_postgres_type(min.c_str(), min.length(),
                                                arrow_type);
@@ -414,7 +414,7 @@ row_group_matches_filter(parquet::Statistics *stats,
                 Datum   upper;
                 int     cmpres;
                 bool    satisfies;
-                std::string max = std::move(stats->EncodeMax());
+                std::string max = stats->EncodeMax();
 
                 upper = bytes_to_postgres_type(max.c_str(), max.length(),
                                                arrow_type);
@@ -434,8 +434,8 @@ row_group_matches_filter(parquet::Statistics *stats,
             {
                 Datum   lower,
                         upper;
-                std::string min = std::move(stats->EncodeMin());
-                std::string max = std::move(stats->EncodeMax());
+                std::string min = stats->EncodeMin();
+                std::string max = stats->EncodeMax();
 
                 lower = bytes_to_postgres_type(min.c_str(), min.length(),
                                                arrow_type);
@@ -1479,7 +1479,7 @@ parquetGetForeignPlan(PlannerInfo * /* root */,
 extern "C" void
 parquetBeginForeignScan(ForeignScanState *node, int /* eflags */)
 {
-    ParquetFdwExecutionState   *festate;
+    ParquetFdwExecutionState   *festate = NULL;
     MemoryContextCallback      *callback;
     MemoryContext   reader_cxt;
 	ForeignScan    *plan = (ForeignScan *) node->ss.ps.plan;
@@ -1792,7 +1792,7 @@ parquetAcquireSampleRowsFunc(Relation relation, int /* elevel */,
 
     delete festate;
 
-    return cnt - 1;
+    return cnt;
 }
 
 extern "C" bool