Skip to content

Commit

Permalink
Add missing Latin decompositions
Browse files Browse the repository at this point in the history
  • Loading branch information
@miguelsousa
miguelsousa committed Sep 24, 2018
1 parent 72dfef4 commit ef7ab8e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Italic/familyGSUB.fea
View file
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ lookup DECOMPOSITION {
sub Ccircumflex by C circumflexcmb.cap;
sub Ccaron by C caroncmb.cap;
sub Cdotaccent by C dotaccentcmb.cap;
sub Dcaron by D caroncmb.cap;
sub Ddotaccent by D dotaccentcmb.cap;
sub Ddotbelow by D dotbelowcmb;
sub Dlinebelow by D macronbelowcmb;
Expand Down Expand Up @@ -222,6 +223,7 @@ lookup DECOMPOSITION {
sub Kdotbelow by K dotbelowcmb;
sub Klinebelow by K macronbelowcmb;
sub Lacute by L acutecmb.cap;
sub Lcaron by L caroncmb.cap;
sub Lcommaaccent by L commabelowcmb;
sub Ldotbelow by L dotbelowcmb;
sub Ldotbelowmacron by L dotbelowcmb macroncmb.cap;
Expand Down Expand Up @@ -353,6 +355,7 @@ lookup DECOMPOSITION {
sub ccircumflex by c circumflexcmb;
sub ccaron by c caroncmb;
sub cdotaccent by c dotaccentcmb;
sub dcaron by d caroncmb;
sub ddotaccent by d dotaccentcmb.cap;
sub ddotbelow by d dotbelowcmb;
sub dlinebelow by d macronbelowcmb;
Expand Down Expand Up @@ -403,6 +406,7 @@ lookup DECOMPOSITION {
sub kdotbelow by k dotbelowcmb;
sub klinebelow by k macronbelowcmb;
sub lacute by l acutecmb.cap;
sub lcaron by l caroncmb;
sub lcommaaccent by l commabelowcmb;
sub ldotbelow by l dotbelowcmb;
sub ldotbelowmacron by l dotbelowcmb macroncmb.cap;
Expand Down
4 changes: 4 additions & 0 deletions Roman/familyGSUB.fea
View file
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ lookup DECOMPOSITION {
sub Ccircumflex by C circumflexcmb.cap;
sub Ccaron by C caroncmb.cap;
sub Cdotaccent by C dotaccentcmb.cap;
sub Dcaron by D caroncmb.cap;
sub Ddotaccent by D dotaccentcmb.cap;
sub Ddotbelow by D dotbelowcmb;
sub Dlinebelow by D macronbelowcmb;
Expand Down Expand Up @@ -227,6 +228,7 @@ lookup DECOMPOSITION {
sub Kdotbelow by K dotbelowcmb;
sub Klinebelow by K macronbelowcmb;
sub Lacute by L acutecmb.cap;
sub Lcaron by L caroncmb.cap;
sub Lcommaaccent by L commabelowcmb;
sub Ldotbelow by L dotbelowcmb;
sub Ldotbelowmacron by L dotbelowcmb macroncmb.cap;
Expand Down Expand Up @@ -358,6 +360,7 @@ lookup DECOMPOSITION {
sub ccircumflex by c circumflexcmb;
sub ccaron by c caroncmb;
sub cdotaccent by c dotaccentcmb;
sub dcaron by d caroncmb;
sub ddotaccent by d dotaccentcmb.cap;
sub ddotbelow by d dotbelowcmb;
sub dlinebelow by d macronbelowcmb;
Expand Down Expand Up @@ -408,6 +411,7 @@ lookup DECOMPOSITION {
sub kdotbelow by k dotbelowcmb;
sub klinebelow by k macronbelowcmb;
sub lacute by l acutecmb.cap;
sub lcaron by l caroncmb;
sub lcommaaccent by l commabelowcmb;
sub ldotbelow by l dotbelowcmb;
sub ldotbelowmacron by l dotbelowcmb macroncmb.cap;
Expand Down

2 comments on commit ef7ab8e

@pauldhunt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msousa For the fix above with carons, the issue may have been a result from me accidentally removing the caron.a glyph from the GOADB, hence its removal from the fonts on build. The fix for Source Sans should involve adding the alternate caron back to the GOADB listing and using it in the decomposition rules you linked to above.

@miguelsousa
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pauldhunt I've opened issue #149 so you can address it in a future round.

Please sign in to comment.