Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining dot above right is conflict with other diacritics #178

Closed
KrasnayaPloshchad opened this issue Sep 7, 2019 · 12 comments
Closed

Comments

@KrasnayaPloshchad
Copy link

KrasnayaPloshchad commented Sep 7, 2019

The combining dot above right is added in Source Sans Pro 3.006, but the usage of this diacritic is not perfect, this mark has some inconsistency with other diacritics or without.
The following letters can produce this problem:

Ó͘ ó͘ (second tone)
Ò͘ ò͘ (third tone)
Ô͘ ô͘ (fifth tone)
Ō͘ ō͘ (seventh tone)
O̍͘ o̍͘ (eighth tone)

BabelPad:
1
LbreOffice:
2

See: https://commons.wikimedia.org/wiki/File:Tai-Oan-Hu-Sia-Kau-Hoe-Po.jpg
This is a photo from the 1st issue of Taiwan Church News, which has some examples for this.

@miguelsousa
Copy link
Member

@KrasnayaPloshchad what is the desired/expected arrangement?

@miguelsousa
Copy link
Member

Test file

<!doctype html>
<html>
<head>
	<meta charset="utf-8">
	<style>

		@font-face{
			font-family: 'Source Sans';
			src: url('./SourceSansPro-Regular.ttf') format('truetype');
		}

		body {
			background-color: #A6A6A6;
		}

		p {
			font-family: 'Source Sans', sans-serif;
			font-size: 50pt;
			margin-top: 0;
			margin-bottom: 0;
		}

	</style>
</head>
<body>
	<p>O&#x0358;</p>
	<p>O&#x0301;&#x0358; O&#x0358;&#x0301; o&#x0301;&#x0358; o&#x0358;&#x0301; (2nd tone)</p>
	<p>O&#x0300;&#x0358; O&#x0358;&#x0300; o&#x0300;&#x0358; o&#x0358;&#x0300; (3rd tone)</p>
	<p>O&#x0302;&#x0358; O&#x0358;&#x0302; o&#x0302;&#x0358; o&#x0358;&#x0302; (5th tone)</p>
	<p>O&#x0304;&#x0358; O&#x0358;&#x0304; o&#x0304;&#x0358; o&#x0358;&#x0304; (7th tone)</p>
	<p>O&#x030D;&#x0358; O&#x0358;&#x030D; o&#x030D;&#x0358; o&#x0358;&#x030D; (8th tone)</p>
</body>
</html>

@KrasnayaPloshchad
Copy link
Author

KrasnayaPloshchad commented Sep 11, 2019

To my eyes, dot above right should be placed near the base letter and not be overlapped with other diacritics. BTW have you saw the link from above?
Sample
(This is modified from screenshot)

@miguelsousa
Copy link
Member

Thanks for the graphic.

BTW have you saw the link from above?

Yes, I did look at the image of a printed page you linked to, but it wasn't obvious what parts of it were important. That's why I requested additional information.

@KrasnayaPloshchad
Copy link
Author

Oh I have thought you have clicked the Original File link while you view on Wikimedia Commons.

@KrasnayaPloshchad
Copy link
Author

Here is the original file from Wikimedia Commons, you can see more details if you want to see what you need.
https://upload.wikimedia.org/wikipedia/commons/0/07/Tai-Oan-Hu-Sia-Kau-Hoe-Po.jpg

@pauldhunt
Copy link
Contributor

pauldhunt commented Jan 9, 2020

@KrasnayaPloshchad Is it possible to get from you a full list of possible combinations with combining dot above right?

@KrasnayaPloshchad
Copy link
Author

OK, here is the list of possible combinations:
Ó͘ 004F 0358 0301, 004F 0301 0358, 00D3 0358
ó͘ 006F 0358 0301, 006F 0301 0358, 00F3 0358
Ò͘ 004F 0358 0300, 004F 0300 0358, 00D2 0358
ò͘ 006F 0358 0300, 006F 0300 0358, 00F2 0358
Ô͘ 004F 0358 0302, 004F 0302 0358, 00D4 0358
ô͘ 006F 0358 0302, 006F 0302 0358, 00F4 0358
Ō͘ 004F 0358 0304, 004F 0304 0358, 014C 0358
ō͘ 006F 0358 0304, 006F 0304 0358, 014D 0358
O̍͘ 004F 0358 030D, 004F 030D 0358
o̍͘ 006F 0358 030D, 006F 030D 0358

pauldhunt added a commit that referenced this issue Feb 3, 2020
Adds characters for U/udieresisbelow to address issue #184.
Updates GSUB features to prevent alternates from blocking formation of small capitals, addressing issue #183.
Adds double circumflex and double macron above to address issue #179.
Attempts to resolve issues with combining dot above right to address issue #178, however there is still some remaining funniness in interaction with text engines and how the character string is formed.
Adds characters for IPA affricate ligatures dzed, dzcurl, tccurl, dzretroflex & tshook to address issue #174.
Converts Sources to UFO version 3 to address issue #148.
Adds heavy quote ornaments because I like using them as ‘scare’ quotes.
@KrasnayaPloshchad
Copy link
Author

@ButTaiwan Can you help?

@ButTaiwan
Copy link

@ButTaiwan Can you help?

You've listed up all the combinations above.

@KrasnayaPloshchad
Copy link
Author

@ButTaiwan So can you make contributions to this font?

@ButTaiwan
Copy link

There are also the 6th tone (U+030C) and the 9th tone (U+030B). (rarely used, but exist.)

So the full list should be:

o͘ o + U+0358
O͘ O + U+0358

ò͘ o + U+0358 + U+0300
́o͘ o + U+0358 + U+0301
ô͘ o + U+0358 + U+0302
̌o͘ o + U+0358 + U+030C
̄o͘ o + U+0358 + U+0304
̍o͘ o + U+0358 + U+030D
̋o͘ o + U+0358 + U+030B

̀O͘ O + U+0358 + U+0300
Ó͘ O + U+0358 + U+0301
Ô͘ O + U+0358 + U+0302
Ǒ͘ O + U+0358 + U+030C
Ō͘ O + U+0358 + U+0304
O̍͘ O + U+0358 + U+030D
Ő͘ O + U+0358 + U+030B

Compatibility sequences:

ó͘ U+00F3 + U+0358 / o + U+0301 + U+0358
ò͘ U+00F2 + U+0358 / o + U+0300 + U+0358
ô͘ U+00F4 + U+0358 / o + U+0302 + U+0358
ǒ͘ U+01D2 + U+0358 / o + U+030C + U+0358
ō͘ U+014D + U+0358 / o + U+0304 + U+0358
o̍͘ o + U+030D + U+0358
ő͘ U+0151 + U+0358 / o + U+030B + U+0358

Ó͘ U+00D3 + U+0358 / O + U+0301 + U+0358
Ò͘ U+00D2 + U+0358 / O + U+0300 + U+0358
Ô͘ U+00D4 + U+0358 / O + U+0302 + U+0358
Ǒ͘ U+01D1 + U+0358 / O + U+030C + U+0358
Ō͘ U+014C + U+0358 / O + U+0304 + U+0358
O̍͘ O + U+030D + U+0358
Ő͘ U+0150 + U+0358 / O + U+030B + U+0358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants