Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add experimentation plugin #22

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: add experimentation plugin #22

wants to merge 7 commits into from

Conversation

buuhuu
Copy link
Collaborator

@buuhuu buuhuu commented May 21, 2024

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented May 21, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@buuhuu buuhuu marked this pull request as draft May 21, 2024 11:59
@buuhuu buuhuu requested a review from ramboz May 21, 2024 11:59
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented May 21, 2024 •
edited
Loading

Page Scores Audits Google
/drafts/drudolph/cards-block PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

ramboz
ramboz approved these changes May 21, 2024
View reviewed changes
Copy link

@ramboz ramboz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

@buuhuu
Squashed 'plugins/experimentation/' changes from 736ec6c..d92b47d
a8babd9 
d92b47d fix: lint (#26)
5195b3f feat: support decimals in split parsing
44ea1df feat: support decimals in split parsing
6d68590 feat: support decimals in split parsing
b48f26a feat: support decimals in split parsing

git-subtree-dir: plugins/experimentation
git-subtree-split: d92b47df145eac38a4c1aa047096f81a94f20e74
@buuhuu
Merge commit 'a8babd9a6dc5e1cd1cbe1710dfe3cf50ca21aa36' into experime…
7ed47de 
…ntation
@buuhuu
Merge remote-tracking branch 'refs/remotes/origin/experimentation' in…
0c3381b 
…to experimentation
omprakashgupta1995 referenced this pull request in WWWPiramalFinanceCOM/piramalfinance Jul 2, 2024
@Sm1pleScr1pt
Merge pull request #22 from shamalijadhav/feature/component-creation
4734921 
 script template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramboz ramboz ramboz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buuhuu @ramboz @fe-lix-