Let Jetty process non-compliant URIs #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commented out. If this is enabled, S3Mock will log AT LOT more.
Enabling "legacy" UriCompliance: Some keys legal in S3 lead to local URIs that are not compliant to RFC-3986. Jetty 12 by default returns 400s for these URIs. Fixes #1686
Optimized some code. Added extended tests for object keys. Added more tests for ErrorResponses using AWS SDK v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating to Spring Boot 3.2 updated Jetty to v12. By default, Jetty will now refuse RFC-3986 non-compliant URIs, which leads to S3Mock refusing object keys that are valid according to S3 API docs.
Enable "legacy" compliance mode to allow those kinds of object keys.
Related Issue
$1686
Tasks