Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form Action Dialog] Required validation of properties on one form action fails other form actions #2052

Open
punithshetty90 opened this issue Mar 6, 2022 · 0 comments

Comments

@punithshetty90
Copy link

punithshetty90 commented Mar 6, 2022

Bug Report

Current Behavior
Create 2-3 form actions with dialog and its property, make sure you have required property on one form dialog

Form Action1 -> Dialog (textfield(required), pathfield(required),select(required),checkbox(required))
Form Action2 -> Dialog (textfield, pathfield,select,checkbox)

Now in form Container choose Form Action 2 and try to submit the form. It fails in the current environment.

Expected behavior/code
Since Form Action2 dialog did not have any required field, it was expected to submit successfully.

Fix Details
Since Form Action2 dialog did not have any required field, it was expected to submit successfully.
So instead of filtering just the input[aria-required=true], coral-multifield[aria-required=true], we need to handle all different types of html tags like select, pathfield, checkbox etc

Environment

  • AEM 6.5 SP10
  • Core Components version: 2.18.0
  • JRE version
    java version "1.8.0_202"
    Java(TM) SE Runtime Environment (build 1.8.0_202-b08)
@punithshetty90 punithshetty90 changed the title AEM Core Components Form Action Dialog validation [AEM Core Components Form Action Dialog] Required validation of properties on one form action fails other form actions Mar 6, 2022
punithshetty90 added a commit to punithshetty90/aem-core-wcm-components that referenced this issue Mar 24, 2022
Issue adobe#2052  : Fix required validation for property on Form Action dialog

Issue adobe#2056 : Fix the issue of saving the property as multiarray when the same name exists in diff form action dialog
@punithshetty90 punithshetty90 changed the title [AEM Core Components Form Action Dialog] Required validation of properties on one form action fails other form actions [Form Action Dialog] Required validation of properties on one form action fails other form actions Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant