-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SITES-5185 - Ensure all GraphQL Queries to publisher are using Persistent Queries and not POST requests #341
Conversation
…tent Queries and not POST requests
@sandru85 you will need to regenerate the MD hash for the immutable file in the pom.xml |
Thx @godanny86 for a reminder - exactly @sandru85 sth similar as in fc34b70 - you can take archetype after changes in adobe/aem-project-archetype#922 and generate dispatcher's pom.xml and sync hashes from there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hashes of immutable files in pom.xml need to be updated - here specifically just one hash of this single changed file.
…g Persistent Queries and not POST requests" This reverts commit fa0c23a.
…tent Queries and not POST requests
…tent Queries and not POST requests
@krystiannowak @godanny86 I also updated the hash and the file as in adobe/aem-project-archetype#922 |
thanks @sandru85 give me some time to merge this. Several of our tutorials use standard POST requests for GraphQL queries. |
…tent Queries and not POST requests
@godanny86 you can check my comment here https://git.corp.adobe.com/Granite/dispatcher-k8s-base/pull/152#issuecomment-4099643 if you would need to enable the queries on prod |
@godanny86 any updates on the validation of this? we would have to get ready and introduce it in the archetyp |
Thanks @sandru85 looks good, i went ahead and merged. |
Description
Disable POST requests for Graphql persisted queries
Related Issue
Motivation and Context
Immutable files should not be different between SDK and archetype.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: