Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-5185 - Ensure all GraphQL Queries to publisher are using Persistent Queries and not POST requests #341

Merged
merged 5 commits into from
May 3, 2022

Conversation

sandru85
Copy link
Member

@sandru85 sandru85 commented Apr 21, 2022

Description

Disable POST requests for Graphql persisted queries

Related Issue

Motivation and Context

Immutable files should not be different between SDK and archetype.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@godanny86
Copy link
Contributor

@sandru85 you will need to regenerate the MD hash for the immutable file in the pom.xml

@krystiannowak
Copy link
Contributor

Thx @godanny86 for a reminder - exactly @sandru85 sth similar as in fc34b70 - you can take archetype after changes in adobe/aem-project-archetype#922 and generate dispatcher's pom.xml and sync hashes from there

Copy link
Contributor

@krystiannowak krystiannowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hashes of immutable files in pom.xml need to be updated - here specifically just one hash of this single changed file.

@sandru85 sandru85 closed this Apr 26, 2022
@sandru85 sandru85 reopened this Apr 26, 2022
@sandru85
Copy link
Member Author

sandru85 commented Apr 26, 2022

@krystiannowak @godanny86 I also updated the hash and the file as in adobe/aem-project-archetype#922

@godanny86
Copy link
Contributor

thanks @sandru85 give me some time to merge this. Several of our tutorials use standard POST requests for GraphQL queries.

@sandru85
Copy link
Member Author

@godanny86 you can check my comment here https://git.corp.adobe.com/Granite/dispatcher-k8s-base/pull/152#issuecomment-4099643 if you would need to enable the queries on prod

@sandru85
Copy link
Member Author

sandru85 commented May 3, 2022

@godanny86 any updates on the validation of this? we would have to get ready and introduce it in the archetyp

@godanny86 godanny86 self-requested a review May 3, 2022 17:00
@godanny86 godanny86 merged commit 1791345 into adobe:main May 3, 2022
@godanny86
Copy link
Contributor

Thanks @sandru85 looks good, i went ahead and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants