Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish login issue #447

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Publish login issue #447

merged 3 commits into from
Mar 22, 2024

Conversation

SachinMali
Copy link
Contributor

@SachinMali SachinMali commented Mar 22, 2024

Description

The login on the Publish service (asmith/asmith) was not working resulting in 204 responses for /system/sling/login/j_security_check. This was happening cause REQUEST_SCHEME value is http (and not https) thus same-origin check fails and forces the CORS processing, thus 204.

Related Issue

#448

Motivation and Context

Handle both http and https REQUEST_SCHEME, the SSL termination might happen before request reaches the dispatcher/Apache POD.

How Has This Been Tested?

Tested on Tech Marketings Sandox and Prod program, see https://wknd.enablementadobe.com/us/en.html

Screenshots (if appropriate):

Screenshot 2024-03-22 at 10 59 53 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@davidjgonzalez davidjgonzalez merged commit 3e2fb44 into main Mar 22, 2024
6 checks passed
@davidjgonzalez davidjgonzalez deleted the publish-login-issue branch March 22, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants