Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CQ-4347346 Removing npx dependency from package.json #974

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

rismehta
Copy link
Contributor

@rismehta rismehta commented Aug 26, 2022

@review @vdua
DOD(Yes)

Description

The archetype projects makes use of front end maven plugin to build the forms front end module. This plugin does not expose npx in the current execution context. Hence, the build fails if npx is not present globally in the execution context.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vdua
Copy link

vdua commented Aug 29, 2022

a little context on the issue will be helpful. The linked issue also doesn't have any details

@rismehta
Copy link
Contributor Author

ll be helpful. The linked issue also doesn't have any details

Thanks. Updated the JIRA with more details

@pankaj-parashar pankaj-parashar merged commit d02bbda into develop Aug 29, 2022
@pankaj-parashar pankaj-parashar deleted the CQ-4347346 branch August 29, 2022 05:45
@vladbailescu vladbailescu added this to the 39 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants