Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about valid Java package name for groupID #978

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

bohnertchris
Copy link
Contributor

@bohnertchris bohnertchris commented Aug 31, 2022

CQDOC-18946

Added note to README.md about valid Java package name for groupID

Description

See above

Related Issue

CQDOC-18946

Motivation and Context

It was a good suggestion from a reader. AdobeDocs/experience-manager-core-components.en#31

How Has This Been Tested?

Same change passed MD validation in our public docs. See PR#214 on the Core Components repo.

Screenshots (if appropriate):

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change
  • [ ]

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kwin
Copy link
Contributor

kwin commented Aug 31, 2022

You should adjust the regex in

<validationRegex>^[a-zA-Z0-9\.\-_]+$</validationRegex>
accordingly to enforce this constraint

@bpauli bpauli merged commit 67ad97d into master Aug 31, 2022
@bpauli bpauli deleted the CQDOC-18946 branch August 31, 2022 12:06
bpauli pushed a commit that referenced this pull request Aug 31, 2022
@bpauli
Copy link
Contributor

bpauli commented Aug 31, 2022

@kwin Thank you for hands up. The regex got adjusted in 544a011

@vladbailescu vladbailescu added this to the 39 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants