Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generated src/methods4docs.js has an extra line in the JSDocs for methods with no parameters #6

Merged
merged 4 commits into from
Mar 31, 2020

Conversation

shazron
Copy link
Member

@shazron shazron commented Mar 12, 2020

see listComputedAttributes, createComputedAttribute

This generates a blank line in the JSDoc, and consequently in the types.d.ts file:

Related Issue

Relates to #5 ?

How Has This Been Tested?

npm run generate-docs

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

shazron added 2 commits March 12, 2020 16:08
…r methods with no parameters

see listComputedAttributes, createComputedAttribute
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #6 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          112       112           
  Branches        15        15           
=========================================
  Hits           112       112           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1e8b1...67e3cba. Read the comment docs.

@shazron shazron merged commit 61eb384 into master Mar 31, 2020
@shazron shazron deleted the methods4docs-fix branch March 31, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant