Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The server url in the swagger spec was protocol relative. It seems like swagger-client is now doing URL validation and the relative url did not pass, causing failures in the e2e tests
Also tests were timing out locally for me. I think this was because the calls to
expect()
with the promises were not being awaited, so I've changed that as wellRelated Issue
Motivation and Context
How Has This Been Tested?
npm run e2e
locallyScreenshots (if appropriate):
Types of changes
Checklist: