Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e tests #61

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: e2e tests #61

merged 1 commit into from
Sep 19, 2023

Conversation

MichaelGoberling
Copy link
Contributor

@MichaelGoberling MichaelGoberling commented Sep 19, 2023

Description

The server url in the swagger spec was protocol relative. It seems like swagger-client is now doing URL validation and the relative url did not pass, causing failures in the e2e tests

Also tests were timing out locally for me. I think this was because the calls to expect() with the promises were not being awaited, so I've changed that as well

Related Issue

Motivation and Context

How Has This Been Tested?

npm run e2e locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #61 (297f3a3) into master (7e63ce6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          136       136           
  Branches        27        27           
=========================================
  Hits           136       136           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@purplecabbage purplecabbage merged commit 6a70c7c into master Sep 19, 2023
7 checks passed
@purplecabbage purplecabbage deleted the fix-e2e-tests branch September 19, 2023 22:57
@shazron shazron mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants