Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for isArray instead #1521

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

dmitrymatio
Copy link
Collaborator

@dmitrymatio dmitrymatio commented Jun 22, 2023

Description

When only one child ({ }) is passed to children prop it can be either { } or [{ }] depending on how it was passed.
This is done for performance and consistent type reasons between rerenders. Changing the length check to isArray check to include this edge case.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dmitrymatio dmitrymatio requested a review from timkim as a code owner June 22, 2023 19:25
@dmitrymatio dmitrymatio merged commit 9fdacdb into main Jun 22, 2023
@dmitrymatio dmitrymatio deleted the fix/tbody-children-arrayof1-error branch June 22, 2023 23:46
@dmitrymatio
Copy link
Collaborator Author

Fixes #1518. Missed tagging the issue sorry 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant