This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Restoring the brackets alias intitialization in appshell_extensions.js #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. This is still going to be required as brackets.app.language was getting accessed even before it was getting initialized in global.js.
|
@nethip A very minor change just for better readability purpose. |
swmitra
approved these changes
Feb 1, 2018
|
@swmitra Thanks for reviewing this! I will update the PR with your review comments. |
Updating comments
swmitra
approved these changes
Feb 1, 2018
nethip
pushed a commit
that referenced
this pull request
Feb 1, 2018
Restoring the brackets alias intitialization in appshell_extensions.js
nethip
added a commit
that referenced
this pull request
Feb 1, 2018
Restoring the brackets alias intitialization in appshell_extensions.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still going to be required as brackets.app.language was getting accessed even before it was getting initialized in global.js.
I have unit tested on Win, Linux and MAC with this change and the change seems to be working fine. Also I tested by hard routing the language to "fr", and Brackets is now correctly able to take the language, defined by
brackets.app.language.Thanks @swmitra for debugging this. Could you please review this?
@abhijitapte It would be great if you can review this as well.