Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Disabled remote-debugging by default and appshell.app.getRemoteDebuggingPort() needs a callback argument to work #668

Merged
merged 6 commits into from
Nov 12, 2019
Merged

Disabled remote-debugging by default and appshell.app.getRemoteDebuggingPort() needs a callback argument to work #668

merged 6 commits into from
Nov 12, 2019

Commits on Nov 6, 2019

  1. Disabled remote-debugging by default and appshell.app.getRemoteDebugg… 

    …ingPort() needs a callback argument to work
    @g-217
    g-217 committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    2a172ef View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2019

  1. Addressing review comments

    @g-217
    g-217 committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    76fc591 View commit details
    Browse the repository at this point in the history

  2. Addressing review comments

    @g-217
    g-217 committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    533c965 View commit details
    Browse the repository at this point in the history

  3. Updating error meesage for port validation

    @g-217
    g-217 authored Nov 11, 2019
    Configuration menu
    Copy the full SHA
    436bdb2 View commit details
    Browse the repository at this point in the history

  4. Addressing review comments from vickramdhawal, also it is not possibl… 

    …e to use g_handler to hold remote-debugging-port as g_handler does not get initialized while we are parsing command line
    @g-217
    g-217 committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    9b903fa View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2019

  1. More error message correction

    @g-217
    g-217 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    de74633 View commit details
    Browse the repository at this point in the history