Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Updates for sprint 33 #85

Merged
merged 5 commits into from
Oct 23, 2013
Merged

Updates for sprint 33 #85

merged 5 commits into from
Oct 23, 2013

Conversation

njx
Copy link
Contributor

@njx njx commented Oct 23, 2013

No description provided.

@ghost ghost assigned jasonsanjose Oct 23, 2013
},
{
"name": "New CSS Rule",
"description": "Quick Edit for CSS (Ctrl+E/⌘E) now has a New Rule button that creates a rule for the currently selected tag/class/id. You can modify the selector after it's created. You can also bring up Quick Edit on a tag/class/id that has no existing rules so that you can create a new rule."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Escape ⌘ to \u2318.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe shorten to something like...?

Quick Edit for CSS (Ctrl+E/⌘E) now has a New Rule button that creates a rule for the currently selected tag/class/id, even when no other rules exist. You can modify the selector after it's created.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I noticed that we also have the Cmd symbol in the older update notification--should I fix it there too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, doesn't hurt.

@jasonsanjose
Copy link
Member

@njx review complete.

@peterflynn
Copy link
Member

I guess we're assuming neither of the new locales will land in time? (adobe/brackets#5378 or adobe/brackets#5372)

@njx
Copy link
Contributor Author

njx commented Oct 23, 2013

It doesn't sound like we had anyone stepping forward to review them yet (and it's been a few weeks). We can ping @couzteau to find out if he can look in the history to see who's reviewed them in the past. But I'd guess they won't land.

},
{
"name": "Regular Expression Substitution",
"description": "When doing a regular expression find/replace, you can use $1, $2, etc. in the replace string to refer to parenthesized subexpressions in the query string."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: When using a regular expression in Find/Replace...

@njx
Copy link
Contributor Author

njx commented Oct 23, 2013

Updated, ready for re-review.

@jasonsanjose
Copy link
Member

Thanks! Re-review done. Merging.

jasonsanjose added a commit that referenced this pull request Oct 23, 2013
@jasonsanjose jasonsanjose merged commit f47d6fe into master Oct 23, 2013
@jasonsanjose jasonsanjose deleted the nj/sprint-33 branch October 23, 2013 22:50
},
{
"name": "New CSS Rule from Quick Edit",
"description": "Use the New Rule button in CSS Quick Edit (Ctrl+E/\u2318E) to create a rule for the currently selected tag/class/id, even if there aren't any existing rules. You can modify the selector after it's created."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was originally thinking we should emphasize that you can now use Quick Edit even when there are no rules, because previously it would do nothing. But maybe this is clear enough.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants