You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Discovered by inspection while fixing #2218. Too risky to fix right now (end of sprint 17) but we should look at them for sprint 18.
_updateRelatedContainer() is both attached as a handler for the host editor "change" event and called from _handleChange(), which seems redundant.
In _updateRelatedContainer(), the width calculation uses lineSpace.scrollWidth. It seems like this should be either lineSpace.width or this.hostEditor.getScrollerElement().scrollWidth.
The text was updated successfully, but these errors were encountered:
As @peterflynn pointed out elsewhere, it's also not clear why the width calculation needs to be so complicated--it seems like it could just use the scroller's scrollWidth, as we do in InlineColorEditor.
Turns out there's a reason for the complex width calculation in MultiRangeInlineEditor--the simplistic thing we're doing in InlineColorEditor doesn't work (see #2218). Additionally, if I change lineSpace.scrollWidth to something like $(lineSpace).outerWidth(), it doesn't seem to get the proper width for some reason. So I'm going to close this bug as NAB, do the refactoring in #2221 to port the MRIE calculation up to InlineTextEditor, and comment why the complex calculation seems to be necessary.
Discovered by inspection while fixing #2218. Too risky to fix right now (end of sprint 17) but we should look at them for sprint 18.
_updateRelatedContainer()
is both attached as a handler for the host editor "change" event and called from_handleChange()
, which seems redundant._updateRelatedContainer()
, the width calculation useslineSpace.scrollWidth
. It seems like this should be eitherlineSpace.width
orthis.hostEditor.getScrollerElement().scrollWidth
.The text was updated successfully, but these errors were encountered: