Color editor is cut off when you scroll right #2218
Comments
|
Is it specific to just color? How is the CSS inline editor getting around On Monday, November 26, 2012, Peter Flynn wrote:
|
|
Oh duh. I had seen this, but I had in the back of my head that we had the same bug in the other inline editors, which I think was true at one point but isn't true now. (I'm not sure why I thought we would have continued to ship with that bug...) We basically need to set the min-width of the widget to the host editor's lineSpace width. We should probably put this logic in the inline widget base class, although the other inline editors (which all happen to be MultiRangeInlineEditors) still need custom logic for this case. I'll see if I can come up with a reasonable fix. |
ghost
assigned
|
(Deleted spurious comment about min-width which turned out not to be true.) |
|
Pull #2222 fixed the bug described above, but causes an inverse bug to occur: when the document is edited to reduce the text width, the inline colorpicker remains too wide and props the horizontal scrolling open. Moving to Sprint 18 to track that work. |
|
reviewed @peterflynn Should we file a new bug for the injection bug and close this one? |
|
This will be fixed when I fix #2221. |
…get base class. This addresses #2221 and #2218. As part of this, cleaned up some issues around how we're doing inheritance: * For #872, switched to using `Object.create()` to hook up prototypes (this avoids subtle bugs when binding event handlers in base classes). * Made it so all child classes call base class implementation for overridden functions (even if the base class impl is empty right now). The one exception is `close()`, which is a bit weird right now--will file a separate issue on this.
|
Confirmed fixed via testing in #2285. |
Result: the entire inline widget, including gray background and top/bottom edge shadows, ends at the edge of the leftmost viewport -- when you scroll to the right there's nothing there but blank space.
Expected: like an inline text editor, the background and shadows should extend all the way across.
The text was updated successfully, but these errors were encountered: