Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Current code hints design may prevent users from entering a new line into the editor when code hint list is open. #2286

Closed
RaymondLim opened this issue Dec 6, 2012 · 4 comments
Assignees
Milestone

Comments

@RaymondLim
Copy link
Contributor

This is a blocking issue for implementing CSS hinting. CSS hinting wants to show property name hints as soon as the user types a { in a CSS rule. Current code hints design then selects the very first item by default when the list pops up. So when the user hits the Return key, then the selected item is inserted into the editor instead of inserting a new line into the editor.

We should allow the user to insert a new line and keep showing the css hint list at the new cursor location. In order to do that we should not have the default selection in the code hint list for CSS hinting.

@ghost ghost assigned RaymondLim Dec 6, 2012
RaymondLim added a commit that referenced this issue Dec 6, 2012
…he default initial selection. This fixes issue #2286
@pthiess
Copy link
Contributor

pthiess commented Dec 10, 2012

Reviewed

@ghost ghost assigned joelrbrandt Dec 14, 2012
@RaymondLim
Copy link
Contributor Author

Re-assigned to Joel since Joel and Ian are working on API changes.

joelrbrandt pushed a commit to iwehrman/brackets that referenced this issue Dec 18, 2012
@joelrbrandt
Copy link
Contributor

Confirming fixed after pull #2387

It's difficult to confirm this is fixed because we don't have any providers that allow inserting whitespace. I tested it by setting selectInitial to false in the object returned from AttrHints.prototype.getHints. Once this is done, pressing "tab" or "enter" with the hint list open inserts appropriate whitespace and moves the hint window appropriately.

@joelrbrandt
Copy link
Contributor

Also note: I did not reassign to @RaymondLim because he is on PTO until after the end of sprint 18.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants