-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Load Mustache with require in each module that uses it #3296
Comments
Reviewed. This might make sense, but we don't want to do it right now because it might break existing extensions. We're planning to overhaul the extensibility API soon, and should discuss this as part of that. So let's not submit any pull requests for this yet :) /cc @dangoor |
@njx Since we changed how we load CodeMirror, should we change this in the current Sprint too, so that extension developers could fix both requires at the same time? But fixing this might be harder depending on how we do the require. |
This issue is unassigned, so marking "Needs Review". |
@TomMalbran We didn't get back to reviewing this in time for release 38. Would you be interested in doing this in release 39? We'd want to do it like CodeMirror where the global is still available but has a DeprecationWarning. |
Sure, I will. That is a good solution to not break anything. |
Fix for #3296: add deprecation warning for global Mustache
Done with a deprecation warning in: #11616 |
Instead of having Mustache being loaded in the index and being a global variable, it can be loaded using require creating a module for it in each module that needs to use Mustache, as every other module in brackets is loaded.
The text was updated successfully, but these errors were encountered: