Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Load Mustache with require in each module that uses it #3296

Closed
TomMalbran opened this issue Mar 30, 2013 · 6 comments
Closed

Load Mustache with require in each module that uses it #3296

TomMalbran opened this issue Mar 30, 2013 · 6 comments

Comments

@TomMalbran
Copy link
Contributor

Instead of having Mustache being loaded in the index and being a global variable, it can be loaded using require creating a module for it in each module that needs to use Mustache, as every other module in brackets is loaded.

@njx
Copy link
Contributor

njx commented Apr 1, 2013

Reviewed. This might make sense, but we don't want to do it right now because it might break existing extensions. We're planning to overhaul the extensibility API soon, and should discuss this as part of that. So let's not submit any pull requests for this yet :)

/cc @dangoor

@TomMalbran
Copy link
Contributor Author

@njx Since we changed how we load CodeMirror, should we change this in the current Sprint too, so that extension developers could fix both requires at the same time?

But fixing this might be harder depending on how we do the require.

@redmunds
Copy link
Contributor

This issue is unassigned, so marking "Needs Review".

@dangoor
Copy link
Contributor

dangoor commented Apr 1, 2014

@TomMalbran We didn't get back to reviewing this in time for release 38. Would you be interested in doing this in release 39?

We'd want to do it like CodeMirror where the global is still available but has a DeprecationWarning.

@TomMalbran
Copy link
Contributor Author

Sure, I will. That is a good solution to not break anything.

marcelgerber pushed a commit that referenced this issue May 1, 2016
Fix for #3296: add deprecation warning for global Mustache
@ficristo
Copy link
Collaborator

ficristo commented Aug 6, 2016

Done with a deprecation warning in: #11616

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants