This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Inline editor overlaps / bleeds across the vertical scrollbar if the original file wasn't tall enought to use a scrollbar #532
Labels
Comments
ghost
assigned
jasonsanjose
added a commit
that referenced
this issue
Apr 5, 2012
njx
added a commit
that referenced
this issue
Apr 5, 2012
|
Since ptheiss isn't here, I regressed it. Verified and closed. |
tvoliter
added a commit
that referenced
this issue
Apr 5, 2012
* origin/master: Code review comments Mix merge midair collision from API rename More code review changes: - Rename CSSAgent methods for clarity - When discarding unsaved changes, revert Document contents after closing main editor instead of before. As a bonus, this makes it easy to skip the revert if the main editor was the only view attached to the Document. Respond to code review: - unregister LiveDevelopment's listeners on CSSDocument when LiveDevelopment stops caring about a particular document - fix misnamed function - Remove the isDirty assertion check in Document._makeNonEditable(). This was breaking many unit tests, which frequently throw away unsaved Documents. It also required somewhat hacky code in notifyFileDeleted() to avoid hitting the assertion in that case. The assertion was sort of out of place anyway: there's nothing intrinsic about destroying _masterEditor and moving the text back into a string that makes unsaved changes not ok; the idea that unsaved changes should be dealt with before closing the main editor is really just a UI feature/rule. When main editor is closed without saving changes, revert the Document to whatever's on disk - because other parts of the UI might still be showing the contents of the Document, and we don't want them to keep reflecting the unsaved (now discarded) changes. Change CSSDocument so it doesn't know about LiveDevelopment, per discussion with Glenn. When a CSSDocument gets a Document "deleted" event, it now dispatches another "deleted" event of its own rather than pinging LiveDevelopment directly to unregister itself; LiveDevelopment is now responsible for listening for this CSSDocument event and unregistering the CSSDocument automatically. - Support CSS files being deleted in live development (now updates browser accordingly) - Fix exception in Document when unsaved changes are discarded but live development still has a ref to the doc (bug #546). More comprehensive fix probably to follow, though - Add warning in DocumentManager when deleting a doc does not clear all refs Fix for #532 and #537
peterflynn
added a commit
that referenced
this issue
Apr 6, 2012
* origin/master: Code review fixes Fire "offsetTopChanged" when inline widget height changes Updated CodeMirror SHA Fixing class selector in _dirtyFlagChangedHandler Code review comments Mix merge midair collision from API rename More code review changes: - Rename CSSAgent methods for clarity - When discarding unsaved changes, revert Document contents after closing main editor instead of before. As a bonus, this makes it easy to skip the revert if the main editor was the only view attached to the Document. Added code to show/hide sidebar. Respond to code review: - unregister LiveDevelopment's listeners on CSSDocument when LiveDevelopment stops caring about a particular document - fix misnamed function Fix exception when cancelling open dialogs - Remove the isDirty assertion check in Document._makeNonEditable(). This was breaking many unit tests, which frequently throw away unsaved Documents. It also required somewhat hacky code in notifyFileDeleted() to avoid hitting the assertion in that case. The assertion was sort of out of place anyway: there's nothing intrinsic about destroying _masterEditor and moving the text back into a string that makes unsaved changes not ok; the idea that unsaved changes should be dealt with before closing the main editor is really just a UI feature/rule. When main editor is closed without saving changes, revert the Document to whatever's on disk - because other parts of the UI might still be showing the contents of the Document, and we don't want them to keep reflecting the unsaved (now discarded) changes. Change CSSDocument so it doesn't know about LiveDevelopment, per discussion with Glenn. When a CSSDocument gets a Document "deleted" event, it now dispatches another "deleted" event of its own rather than pinging LiveDevelopment directly to unregister itself; LiveDevelopment is now responsible for listening for this CSSDocument event and unregistering the CSSDocument automatically. - Support CSS files being deleted in live development (now updates browser accordingly) - Fix exception in Document when unsaved changes are discarded but live development still has a ref to the doc (bug #546). More comprehensive fix probably to follow, though - Add warning in DocumentManager when deleting a doc does not clear all refs Fix for #532 and #537 Conflicts: src/editor/CSSInlineEditor.js src/editor/Editor.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Maybe a corner case but if the inline editor extends the height such that a scroll bar is added the inline editor still overlaps.
The text was updated successfully, but these errors were encountered: