Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Unit test failure in ExtensionUtils #7611

Closed
njx opened this issue Apr 23, 2014 · 7 comments
Closed

Unit test failure in ExtensionUtils #7611

njx opened this issue Apr 23, 2014 · 7 comments
Assignees
@zaggino
Labels
fixed but not closed high priority

Comments

@njx
Copy link
Contributor

njx commented Apr 23, 2014

I'm seeing this on OS X 10.9.

  1. Run the Extension Utils tests in the Integration tab

Result: errors in "should attach LESS style sheets using absolute url".

Error: Expected '[undefined] promise rejected with: [object Object]' to be '(expected resolved instead)'.
Error: Expected '[loadStyleSheet: file:///Users/nj/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/test/spec/ExtensionUtils-test-files/basic.less] promise rejected with: [object Object]' to be '(expected resolved instead)'.
Error: Expected '[loadStyleSheet: file:///Users/nj/github/brackets-shell/xcodebuild/Release/Brackets.app/Contents/dev/test/spec/ExtensionUtils-test-files/basic.less] promise rejected with: [object Object]' to be '(expected resolved instead)'.
@njx
Copy link
Contributor Author

njx commented Apr 23, 2014

Looks like this was caused by #7522 (87745c7). @zaggino, could you take a look?

@njx
Copy link
Contributor Author

njx commented Apr 23, 2014

/cc @redmunds (reviewer)

@njx
Copy link
Contributor Author

njx commented Apr 23, 2014

Wonder why our build machine hasn't been complaining about this one...

@zaggino
Copy link
Contributor

zaggino commented Apr 23, 2014

ah, got it ... the second check should not be changed ... pr in a moment

@njx njx mentioned this issue Apr 23, 2014
Merged
@zaggino
Copy link
Contributor

zaggino commented Apr 24, 2014

pr #7612

@redmunds redmunds mentioned this issue Apr 24, 2014
Merged
redmunds added a commit that referenced this issue Apr 24, 2014
@redmunds
Merge pull request #7612 from adobe/zaggino/issue-7611
e3bc31c 
fixes #7611
@redmunds
Copy link
Contributor

FBNC back to @njx

@redmunds redmunds reopened this Apr 24, 2014
@njx
Copy link
Contributor Author

njx commented Apr 24, 2014

Confirmed. Thanks for jumping on this @zaggino.

@njx njx closed this as completed Apr 24, 2014
@core-ai-bot core-ai-bot mentioned this issue Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zaggino zaggino

Labels
fixed but not closed high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@njx @zaggino @redmunds