-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Shortcuts with Ctrl+Alt modifiers may prevent some keyboard users from inputting non-English text. #8666
Comments
Are you on Linux? If you're on Windows, we've already disabled Ctrl+Alt+S shortcut for your keyboard layout and altGr+S should be working for you to type Ș. So I wonder what version you're running if you're on Windows. |
Windows 8.1, sprint 42. |
Yes, I can reproduce it on my win7. I thought I've fixed it for all keyboard layouts and somehow my changes are not working for Romanian keyboard layout. |
Keyboard layout: Romanian (Programmers). |
@RaymondLim I put a card for this into nomination if this seems less than half a day of dev work to fix this issue please move it into development any time. Otherwise please reassign to @ryanstewart to review; we decided to keep a medium priority with this milestone after discussing to bump it to a high immediately. |
This issue is different from #7859 that I fixed and thought my fix also covers this. Actually, there are two categories of altGr key issues.
In order to fix the issue we need to detect keyboard layout in Brackets shell code and make that keyboard language info available to JavaScript side. Then on JavaScript side we have to use that info to filter out all shortcuts already preassigned to a specific keyboard layout. I estimate that I need two days of work to fix this issue. |
Update title to better describe the issue. (was Alt Shortcuts) |
To input Ș we need just Right ALT + S (without Ctrl). |
@AndreiTelteu Right Alt is the same as Ctrl+Alt combination and is called altGr key. |
Sorry i didn't knew that. |
No worries. You can get more details here. |
Reviewed for 1.0 milestone (also adding Nominations label) |
Extension is available |
Thanks a lot @mardraze, such a useful feature! |
confirming that @mardraze extension fixes the issue on windows for Polish programmer's keyboard. |
@AndreiTelteu @mardraze @chylex @piotr-cz There is a pull request (#10109) to fix this issue -- please test if you have the time. |
@AndreiTelteu @mardraze @chylex @piotr-cz We have posted Brackets 1.1 Prerelease builds with this support. |
Sorry for the delay, can confirm it works, thanks! |
Can confirm too, issue is resolved in v1.1 |
Hi.
My Romanian keyboard layout is set so Right Alt + S writes Ș, but on brackets Alt + S goes for save.
I need to disable the Alt + (s,a,q,i,t) (if any).
Thanks.
Tasks
The text was updated successfully, but these errors were encountered: