Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Extensions should load after the core Brackets UI is initialized #968

Closed
jasonsanjose opened this issue May 31, 2012 · 3 comments
Closed
Assignees

Comments

@jasonsanjose
Copy link
Member

In #943, extension loading was changed to support extension unit tests. This change was made to ensure the test Brackets window was fully initialized before the test begins execution.

Issue #954 shows that extension load failures now crash Brackets on init.

Brackets should revert to it's old behavior of completely loading the UI before loading extensions. To support unit tests, we will fire a new event (or some equivalent) to ensure extensions are loaded before extension unit tests execute.

@ghost ghost assigned jasonsanjose May 31, 2012
@pthiess
Copy link
Contributor

pthiess commented Jun 1, 2012

I agree this needs to be fixed in this sprint, I may even have proposed it being a high priority bug due to it's impact.

@jasonsanjose
Copy link
Member Author

Closing.

@peterflynn
Copy link
Member

Note: ordering extension loading this way is now much less critical because #1968 makes us able to catch errors that occur during extension loading.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants