Upgrade to Require 2.1.1 and catch errors during extension loading #1968
Conversation
…oading (ensuring APP_READY fires even if an extension is broken). Also: ensure APP_READY fires in the event the entire extensions dir is inaccessible; and improve reporting of exceptions thrown by APP_READY or HTML_READY handlers.
|
Note: this breaks the PhoneGap Build plugin because it's using a RequireJS API that was removed in 2.x. I've put up a pull request to fix it: adobe/brackets-phonegap#27. |
ghost
assigned 
| console.log("Exception when calling a 'brackets done loading' handler"); | ||
| console.log(e); | ||
| console.error("Exception when calling a 'brackets done loading' handler:"); | ||
| console.error(e.stack); |
There was a problem hiding this comment.
Do both of these lines need to be console.error()? If an exception is thrown, it shows up as 2 errors in the console.
|
Done with initial review. I've been running this branch for a while now and everything is working great (except the phonegap build plugin, as you noted). I wonder if the stack dumps should be console.log() instead of console.error(). The preceding line is always an error anyway, so I don't think we need an additional error badge. |
Fix JSLint error that was introduced by 301289b.
|
Changes pushed. I also fixed a JSLint warning I happened to notice in an unrelated unit test file. |
|
Looks good. Merging. |
Upgrade to Require 2.1.1 and catch errors during extension loading
This ensures APP_READY fires even if an extension is broken.
Also: ensure APP_READY fires in the event the entire extensions dir is inaccessible; and improve reporting of exceptions thrown by APP_READY or HTML_READY handlers.