-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Remove .jsx from Javascript file extensions and create an jsx-mode #12052
Conversation
@petetnt we have used the convention in the past to put in the title of the PR "[DO NOT MERGE]" or something to that extent for a more visual cue of the status of the PR. Correction. I think the convention was "[REVIEW ONLY]"... :) |
Looking forward to this :) |
@MiguelCastillo Yeah that's probably a good idea. I changed the title 👍 |
I created and added a label to track PRs that shouldn't be merged. :) Easier to filter |
CodeMirror is now merged so this should be too. Ping @MiguelCastillo |
@petetnt Yup - this is my next item on the list :) |
I think this is an easy merge now. Is there something blocking this, @MiguelCastillo @petetnt? |
@marcelgerber nope AFAIK. Just needed the CodeMirror update. Cannot remove the do not merge tag myself but there shouldn't be anything to stop merging this, actually merging this would be really beneficial 💰 |
Yeah you guys are right. I completely disappeared for a bit and neglected. Merging now. |
It works very nicely too! Thank you @petetnt. |
This PR removes
.jsx
from Javascript file extensions and creates an separate jsx-mode.