Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Updated default dark-theme to hightlight errors #13068

Merged
merged 1 commit into from
Jan 29, 2017

Conversation

retornam
Copy link
Contributor

Updated the default dark theme to ensure that .cm-error gets applied
last.

Before:
screen shot 2017-01-26 at 4 17 08 pm

After:
screen shot 2017-01-26 at 4 17 49 pm

This pull request fixes issue #13057

Updated the default dark theme to ensure that .cm-error gets applied
last.
@@ -59,7 +59,7 @@
color: #fff;
}
.inline-widget .CodeMirror-gutter-elt {
color: #767676;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not required. Probably a newline has caused this diff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swmitra there were some extra spaces after the semi colon, my editor is configured to string extra spaces.

@swmitra
Copy link
Collaborator

swmitra commented Jan 27, 2017

@retornam Thanks a lot for contributing to Brackets 👍. The changes looks good to me barring one really minor comment. But I guess cla check failed in the ci build. Can you please sign the cla doc first?
@petetnt Can you please have a look at the changelist?

@petetnt petetnt self-requested a review January 27, 2017 08:51
@retornam
Copy link
Contributor Author

Thanks I've signed the CLA.

Copy link
Collaborator

@petetnt petetnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants