Live development refactoring

[jdiehl]

As suggested in #1340:

• Inspector and agents now use jQuery events. I mapped Inspector.on and .off to jQuery's methods to make migrating to the new events easier. Feel free to take these methods out (they are not used).
• LiveDevelopment.open() now returns a promise
• I removed the load event handler (it is triggered otherwise)
• Status codes are now constants (the mapping remains the same to support >= STATUS_CONNECTING to check if there is an connection attempt or an active connection in one line)

[jasonsanjose]

I'm seeing 1 unit test failure in Live Development "should establish a browser connection for an opened html file"

Error: An attempt was made to use an object that is not, or is no longer, usable.
    at _send (file://localhost/Users/jasonsj/Github/brackets-app/brackets/src/LiveDevelopment/Inspector/Inspector.js:143:17)
    at Object.close (file://localhost/Users/jasonsj/Github/brackets-app/brackets/src/LiveDevelopment/LiveDevelopment.js:443:31)
    at cssOpened (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/spec/LiveDevelopment-test.js:124:33)
    at jasmine.Block.execute (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/thirdparty/jasmine-core/jasmine.js:1024:15)
    at jasmine.Queue.next_ (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at goAgain (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/thirdparty/jasmine-core/jasmine.js:1832:18)

timeout: timed out after 10000 msec waiting for Waiting for to close inspector

[jdiehl]

I do not get this error, and do not understand how it can occur. The variable in question (Inspector.js:143:17) is method, which is not an object but a string. The call that is issued is window.close() on the client side to close the active tab after a live development session. Can you try closing an active live development session manually and verify that the error actually occurs?

Other than that, I am not sure how I can help in fixing this issue.

On Aug 17, 2012, at 19:03 , Jason San Jose notifications@github.com wrote:

I'm seeing 1 unit test failure in Live Development "should establish a browser connection for an opened html file"

Error: An attempt was made to use an object that is not, or is no longer, usable.
at send (file://localhost/Users/jasonsj/Github/brackets-app/brackets/src/LiveDevelopment/Inspector/Inspector.js:143:17)
at Object.close (file://localhost/Users/jasonsj/Github/brackets-app/brackets/src/LiveDevelopment/LiveDevelopment.js:443:31)
at cssOpened (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/spec/LiveDevelopment-test.js:124:33)
at jasmine.Block.execute (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/thirdparty/jasmine-core/jasmine.js:1024:15)
at jasmine.Queue.next (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/thirdparty/jasmine-core/jasmine.js:1842:31)
at goAgain (file://localhost/Users/jasonsj/Github/brackets-app/brackets/test/thirdparty/jasmine-core/jasmine.js:1832:18)

timeout: timed out after 10000 msec waiting for Waiting for to close inspector
—
Reply to this email directly or view it on GitHub.

[jasonsanjose]

Interesting that the version number at the top of this object isn't updated. Just to document the diff, whats the origin and rev of this file?

[jdiehl]

Origin is WebKit: http://svn.webkit.org/repository/webkit/trunk/Source/WebCore/inspector/Inspector.json
(the link can be found in jsdoc.rb)

That is all the info, I have.

[jasonsanjose]

Looks good. I wasn't able to reproduce the unit test failure once I closed chrome before launching the tests. Merging. Thanks for the bug fix!