This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Refactor SVG files #1453
Merged
Refactor SVG files #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No performance reasons, but I could not get the filters to render correctly in hidpi resolutions. I'll try out your assets on the retina MacBook and see how they look. |
ghost
assigned
|
Looks good. I thought from the comment you had switched to filters, but it still uses the pseudo shadows, so it has no effect on hidpi. Thanks for the clean up. |
|
I wanted to switch to filters, but I was thinking there are some reason for not to use them. I will send another pull request with filters ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder, is there any performance reason to not use SVG filters for shadows?