This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
INITIAL REVIEW: Update path to welcome project in newer builds #1639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gruehle
This is a proposed fix for #1512. It's a little more code change than I'd like, so I'm just putting this up for initial review now.
The overall changes are:
Note that we don't detect welcome projects from before this sprint, so people upgrading from Sprint 13 to Sprint 14 will still have the old welcome project in their last opened project/recent projects list. (However, the last opened project/recent projects list from older sprints will still be recognized even though they're in a different format.) We'll need to release note this.
The main concerns I have are that there are a fair number of cases that are affected, and the logic in the recent projects dropdown has changed enough that we really need to do a thorough retest. I've tested the ones I could think of, but there might be more.
Here are the cases I can think of, along with their expected behavior:
Note that this also means that the last opened project/recent projects won't be saved if you downgrade from >=Sprint 14 to <Sprint 14.
We need to add some unit tests for all this stuff. Some of these cases will be tricky to unit test, as it involves prefs being set up in certain ways and different source folders. Probably the only way to do it is to manually synthesize the prefs for each test. (Also, there weren't any unit tests for the recent projects dropdown to begin with...a by-product of the fact that the criteria for the last sprint were "just check it in" :) We probably need to write some.)