This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Adding numpad keys to brackets and increase font size #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -186,8 +186,13 @@ define(function (require, exports, module) { | |||
| // by subtracting KeyEvent.DOM_VK_0 from keycode. ie. [48-57] --> [0-9] | |||
| if (keycode >= KeyEvent.DOM_VK_0 && keycode <= KeyEvent.DOM_VK_9) { | |||
| return String(keycode - KeyEvent.DOM_VK_0); | |||
| // Do the same with the numpad numbers | |||
| // by subtracting KeyEvent.DOM_VK_NUMPAD0 from keycode. ie. [96-106] --> [0-9] | |||
There was a problem hiding this comment.
Typo: should be [96-105].
ghost
assigned 
|
Nice work! Done with initial review. |
|
Looks good! Merging. |
RaymondLim
added a commit
that referenced
this pull request
Oct 25, 2012
Adding numpad keys to brackets and increase font size
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add numpad keys to brackets, allowing to use them for toggle line comment, increase font size, decrease font size, reset font size and future functions that could need them.
This should fix the issue #1172