This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Disable Rename on Second Click #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Reviewing... |
|
Looks good, works fine, but commenting out that code causes a JSLint error (empty block). Might need to just comment out the whole contents of the |
|
Change pushed |
|
Thanks Randy! Merging. |
peterflynn
added a commit
that referenced
this pull request
Dec 20, 2012
Disable Rename on Second Click
Closed
This was referenced Aug 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to disable this new feature due to issues described in #2394 and #2411. I attempted to fix these issues in pull request #2412, but ran out of time.
@gabriellcardoso I want to give you a head's up that we're disabling this for Sprint 18 due to issues described above. You're welcome to try to fix them for Sprint 19. FYI, I think the trickiest problem to fix will be fixing the click handler to pause long enough to verify it's not a double-click. let me know if you have any questions.