-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Inform the user about missing libraries #2440
Conversation
Conflicts: src/strings.js
This reverts commit 5fa1b50.
Conflicts: src/debug/DebugCommandHandlers.js src/strings.js
Conflicts: src/brackets.js src/command/Menus.js src/debug/DebugCommandHandlers.js src/nls/strings.js src/strings.js src/thirdparty/i18n.js
document.write("<p>If you have checked up Brackets from github, please update the submodules by running the following command:</p>"); | ||
document.write("<pre>git submodule update --init</pre>"); | ||
document.write("<p><a href=\"#\" onclick=\"window.location.reload()\">Reload Brackets</a></p>"); | ||
}, 1000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably bump this up to 2 seconds in case the user is running on a really slow (or bogged down) machine.
@jdiehl - thanks for submitting this. It is definitely one of the top support issues when running from source. I have some suggestions on the wording to simplify things a bit: Missing Libraries Oops! One or more required libraries could not be found. If you are running from a local copy of the Brackets source, please make sure submodules are updated by running
If you're still having problems, please contact us via one of the channels mentioned in the README |
Thanks for the suggestion, changed it! |
I am opening the local version of the README in a new window to avoid users being stuck in the README (there are no navigation buttons). |
Merged with a couple minor wording tweaks in 90519fa |
This seems to be a recurring issue on the mailing list, so it might make everyone's life easier to simply inform the user about missing libraries and how to fix that inside brackets. I added a simple script at the end of bracket.html that checks whether all required libraries are loaded after a fixed time interval (1 second) and informs the user if something is missing.