This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Test and fix for #2464 #2465
Merged
Test and fix for #2464 #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| setContentAndUpdatePos(pos, | ||
| ["<html>", "<body>"], | ||
| "<div ", "", | ||
| ["<div id='foo' class='clazz'>", "</body>", "</html>"]); |
There was a problem hiding this comment.
Can you add "</div>", before "</body>"?
|
Done initial review. Just one minor issue in unit test -- need to add the closing div tag to make it a valid html. |
|
@RaymondLim Fixed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible fix for the issue detailed in #2464. It also includes the test for it.
This feels more like a workaround than a real fix, but may be good enough if codemirror token behavior is not to be changed.